Deprecate getters and setters for deprecated configuration properties consistently

[mbhave]

When we deprecate a configuration property, we add @DeprecatedConfigurationProperty to the getter along with a @Deprecated on the getter and setter. We don't do this consistently though. This is one example where the getter and setter don't have @Deprecated.

[shahaf-sameach]

hi, would like to be a new contributor, can I take this for starters?

[snicoll]

@shahaf-sameach Thanks for the offer. Yes, please give that a try and let us know how it goes.

[snicoll]

I think going forward we should also make sure to add @since on the deprecation message, see #20991.

@shahaf-sameach how is it going by the way? Do you need any help?

[philwebb]

We could add a since attribute on @DeprecatedConfigurationProperty

[shahaf-sameach]

hi @snicoll, thank you, just wanted to ask if that is straight forward as it seems, look for any @Deprecated occurrence at a getter, and check the setter also annotated, am I missing something?

[snicoll]

Yes.