TomcatReactiveWebServerFactory does not call getTomcatWebServer to create the TomcatWebServer

[wilkinsona]

TomcatReactiveWebServerFactory.getWebServer(HttpHandler) doesn't delegate to TomcatReactiveWebServerFactory.getTomcatWebServer(Tomcat) and instead creates the TomcatWebServer instance directly. This makes the javadoc for getTomcatWebServer(Tomcat) misleading:

Factory method called to create the TomcatWebServer. Subclasses can override this method to return a different TomcatWebServer or apply additional processing to the Tomcat server.

[dongxiaofu]

@wilkinsona, I want to modify TomcatReactiveWebServerFactory.getWebServer(HttpHandler),

replacing return new TomcatWebServer(tomcat, getPort() >= 0); with return getTomcatWebServer(tomcat);.

If you agree with me,then may I work on the issue?

[wilkinsona]

Thanks for the pull request, @gangganghong. The change you have proposed is exactly what I had in mind. I'll close this issue in favour of your PR.

[dongxiaofu]

Thanks.

[wilkinsona]

Reopening as the pull request was closed.