Skip to content

Incorrect Javadoc regarding default Tomcat async request timeout #19056

@adammichalik

Description

@adammichalik

Follow-up on spring-projects/spring-framework#24030

In org.springframework.boot.autoconfigure.web.servlet.WebMvcProperties.Async#requestTimeout the Javadoc says

/**
 * Amount of time before asynchronous request handling times out. If this value is
 * not set, the default timeout of the underlying implementation is used, e.g. 10
 * seconds on Tomcat with Servlet 3.
 */

However, actually the default timeout in Tomcat is 30 seconds as noted in this comment: https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/core/AsyncContextImpl.java#L74 and indeed set to the default 30000 ms here: https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/connector/Connector.java#L134

The incorrect explicit values were removed from Spring WebMvc Javadocs and so should the Javadoc in Spring Boot.

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: supersededAn issue that has been superseded by another

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions