HttpRequestMethodNotSupportedException prevents timing in WebMvcMetricsFilter

[izeye]

This was originally reported in micrometer-metrics/micrometer#1011.

HttpRequestMethodNotSupportedException prevents timing in WebMvcMetricsFilter and a simple fix seems to be just ignoring HttpRequestMethodNotSupportedException in filterAndRecordMetrics() and using null handler but I'm opening an issue in case there's a better approach for it. If ignoring HttpRequestMethodNotSupportedException is a right approach, I can create a PR for it.

Here is a sample project to reproduce it: https://github.com/izeye/sample-micrometer-spring-boot/tree/micrometer-gh-1011-2.1.0

Reproduction steps as follows:

• Run the application.
• Open http://localhost:8080/login in a web browser.
• Submit anything.

[wilkinsona]

Thanks for the report, @izeye, but, ideally, I think this should be tackled in Spring MVC. The javadoc for HandlerMapping.getHandler(HttpServletRequest) currently says that it "returns null if no match was found. This is not an error". It also says that it will throw an exception "if there is an internal error". I would expect an unsupported HTTP request method to result in null being returned as it is not an internal error.

Can you please open a Spring Framework JIRA ticket for this and comment here with a link to it? I'll close this one for now. We can re-open it if necessary depending on the outcome of the Framework issue.

[izeye]

@wilkinsona Thanks for the quick feedback! I created https://jira.spring.io/browse/SPR-17518

[wilkinsona]

SPR-17518 has resulted in the addition of a new request attribute that makes the handler available. We need to rework WebMvcMetricsFilter to use it rather than HandlerMappingIntrospector.

[bclozel]

Great! This will avoid duplicate handler lookups and improve runtime performance when actuator is enabled.