WebRequestTraceFilter calls methods on the request and response to retrieve information that then isn't included in the trace

[hpresnall]

org.springframework.boot.actuate.trace.WebRequestTraceFilter.getTrace() is calling a number of methods on the request even when they are not going to be included in the trace. The issue is that the add method is passed an Include and the data to include. This function calls that generate the data are called even if add never actually adds anything to the trace.

This came up during performance testing of an application at loads of about 500 requests per second. In particular, the call to getPathTranslated() was showing up in profiles as taking 5% of the overall execution time. On Linux with openjdk, this method makes native filesystem calls which are relatively slow. This is especially bad since DEFAULT_INCLUDES does not include this data and it's never put in the trace. If I remove this one call, I see between a 5% and 50% improvement in throughput depending on total throughput and concurrency.

The add method should be reworked so that the data is not generated until it is added to the trace.

[wilkinsona]

Thank you for the detailed analysis.

[wilkinsona]

I've assigned this to 2.0.x but, looking at the class name you've mentioned, it looks like you're using Spring Boot 1.5 (or earlier). Can you please confirm the version you're using?

[wilkinsona]

Looking at the code, this problem is specific to 1.5. In 2.0, values are only retrieved from the request and response if they are going to be included in the trace.

[hpresnall]

Yes, this is 1.5. Looks like things were reworked in 2.0.
I don't know if our project could migrate to 2.0 immediately.