Skip to content

GH-5023: Add empty collection handling to RecursiveCollectionLineAggregator #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+9 −1
Closed

GH-5023: Add empty collection handling to RecursiveCollectionLineAggregator #5038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf37b7b
Add empty collection handling to RecursiveCollectionLineAggregator
florian-serraille Oct 20, 2025
ef75ed2
Merge branch 'spring-projects:main' into GH-5023
florian-serraille Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...framework/batch/infrastructure/item/file/transform/RecursiveCollectionLineAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ public void setLineSeparator(String lineSeparator) {

@Override
public String aggregate(Collection<T> items) {
if (items.isEmpty()) {
return "";
}
StringBuilder builder = new StringBuilder();
for (T value : items) {
builder.append(delegate.aggregate(value)).append(lineSeparator);
Expand Down
7 changes: 6 additions & 1 deletion ...work/batch/infrastructure/item/file/transform/RecursiveCollectionLineAggregatorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import org.junit.jupiter.api.Test;

import org.springframework.batch.infrastructure.item.file.transform.RecursiveCollectionLineAggregator;
import org.springframework.util.StringUtils;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand All @@ -34,6 +33,12 @@ class RecursiveCollectionLineAggregatorTests {

private final RecursiveCollectionLineAggregator<String> aggregator = new RecursiveCollectionLineAggregator<>();

@Test
void testSetDelegateAndPassEmptyCollection() {
aggregator.setDelegate(item -> "bar");
assertEquals("", aggregator.aggregate(Collections.emptyList()));
}

@Test
void testSetDelegateAndPassInString() {
aggregator.setDelegate(item -> "bar");
Expand Down