Fix/null pointer exception parallel remove map step registry #4982
+88
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and getStep Signed-off-by: ThomasKrieger <[email protected]>
Resolves spring-projects#4981 Signed-off-by: Thomas Krieger [email protected] Signed-off-by: ThomasKrieger <[email protected]>
ThomasKrieger
force-pushed
the
fix/NullPointerException-parallel-remove-MapStepRegistry
branch
from
8d90e13 to
afa57b1
Compare
|
Hi @ThomasKrieger , Thank you for opening this PR! However, if you manage to find other issues thanks to vmlens, you are welcome to contribute other PRs. Please note that we have no plan to add vmlens as a dependency and use its maven plugin, but we are open to merge any bug-fix that it may detect. Keep the good work up on vmlens! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4981
replaced map.containsKey with get and != null in MapStepRegistry
And test with vmlens to test the race condition