Overhaul MongoDB Dao to fix various bugs #4898
Conversation
|
Thank you for the PR! I think that is the right fix. However, can you please add a test that covers the case? With that in place, the PR should be good merge. |
fmbenhassine
added
pr-for: bug
in: core
status: waiting-for-reporter
| .stream() | ||
| .filter(stepExecution -> stepExecution.getName().equals(stepName)) | ||
| .min(Comparator | ||
| .max(Comparator |
There was a problem hiding this comment.
I believe it would be also necessary to fix line 114 which is not correct comment anymore.
- // first one
+ // last one
quaff
changed the title
MongoStepExecutionDao::getLastStepExecution
@fmbenhassine Please review. |
fmbenhassine
added
status: feedback-provided
|
Very interesting fixes in this PR! However, I was not sure about the change of I wanted to cherry-pick the change to fix #4896 but I couldn't as this PR has a single commit and I didn't want to amend yours. I took the patch in 845f2c3 and gave you credits, thank you! So please remove that part from the PR and I will merge the remaining changes in RC2. This PR addresses different things (adds missing methods like |
fmbenhassine
added
status: waiting-for-reporter
Should I close this PR and create other PRs? |
|
As you wish. You can keep a single PR with different commits so I can cherry pick what can be back-ported to 5.2.x. Otherwise you can open separate PRs if you want. Many thanks upfront 🙏 |
Signed-off-by: Yanming Zhou <[email protected]>
1. Implement method `deleteJobInstance()` 2. Fix missing range check for `List.subList()` 3. Introduce MongoJobInstanceDaoIntegrationTests Signed-off-by: Yanming Zhou <[email protected]>
1. Implement method `deleteJobExecution()` 2. Fix find job executions ordering 3. Convert Date to LocalDate/LocalTime/LocalDateTime 4. Introduce MongoJobExecutionDaoIntegrationTests Signed-off-by: Yanming Zhou <[email protected]>
1. Implement method `deleteStepExecution()` 2. Fix NPE if stepExecutionId not exists when get step execution 3. Fix count step executions by step name 4. Introduce MongoStepExecutionDaoIntegrationTests Signed-off-by: Yanming Zhou <[email protected]>
@fmbenhassine I break it down to 4 commits. |
3 participants
Now it's covered by tests copied from JDBC implementation.
See GH-4896