Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Extract bean name string literals to constants #4761

Conversation

JunggiKim
Copy link
Contributor

@JunggiKim JunggiKim commented Feb 9, 2025

Refactoring Proposal

Extract hardcoded bean name string literals to static final constants in BatchRegistrar class.

Changes

  • Added static final constants for bean names (JOB_REPOSITORY, JOB_EXPLORER, etc.)
  • Replaced string literals with the corresponding constants
  • No functional changes

- Extract hardcoded bean name strings to static final constants
- Improve code maintainability and reduce the risk of typos
- No functional changes

Signed-off-by: kimjg <[email protected]>
@JunggiKim JunggiKim force-pushed the refactor/extract-bean-name-constants branch from 982b5aa to 48683af Compare February 9, 2025 08:08
@JunggiKim JunggiKim changed the title Refactor: Extract bean name string literals to constants Refactor Extract bean name string literals to constants Feb 10, 2025
@fmbenhassine
Copy link
Contributor

LGTM 👍 Rebased and merged as 3b0868d. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants