Fix index-creating queries in ddl script

[yoseplee]

Motivation

• Me and my colleague are recently trying MongoDB as a job repository.
• According to the document I was able to access the example DDL scripts.
• I run the script without reading it carefully, and it failed, and fixed it.
  • Usage of createIndex() was wrong.
  • Name of the index duplicated which made error as well.

What I did

• Fixed createIndex() query.
  • According to the syntax, it should have looked like db.collection.createIndex(<keys>, <options>, <commitQuorum>) but was likedb.collection.createIncex(<name>, <keys>, <commitQuorum>).
• Renamed duplicated index names of BATCH_JOB_EXECUTION collection.

Note

• Unlike the script, I read through the document and found suggestions about indexing metadata tables.
• Please let me know the duplicated name in the script is intended.
• In addition, improving integration test case that is introduced in What's new in Spring Batch 5.2 might be a good idea.

[fmbenhassine]

Hi, thank you for the PR!

Regarding the syntax issue, which version of mongo db are you using? Is it the same as the one in the integration test?

Please let me know the duplicated name in the script is intended.

Indeed, I think the following indexes have duplicate names:

db.getCollection("BATCH_JOB_EXECUTION").createIndex("job_instance_idx", {"jobInstanceId": 1}, {});
db.getCollection("BATCH_JOB_EXECUTION").createIndex("job_instance_idx", {"jobInstanceId": 1, "status": 1}, {});

The second one should be something like job_instance_status_idx. Please update the PR accordingly.

In addition, improving integration test case that is introduced in What's new in Spring Batch 5.2 might be a good idea.

yes probably that was missed, the test should include the index creation statements exactly in the same way as in the script schema-mongodb.js. Please add that to the PR and it should be good to merge.

Many thanks upfront!