Attempt to close all delegate writers even when some fail #4750
+56
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elimelec Burghelea <[email protected]>
|
LGTM 👍 Thank you for reporting and fixing the issue! I planned this for the next patch release. |
fmbenhassine
changed the title
fmbenhassine
pushed a commit
that referenced
this pull request
Feb 20, 2025
Issue #4750 Signed-off-by: Elimelec Burghelea <[email protected]>
|
Rebased and merged bd8f9a8. Thank you for your contribution! I think the same issue can happen for delegates in the composite reader, so if you want to contribute the same fix then you are welcome. Otherwise please let me know and I will take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When a delegate writer fails during close(), the original implementation would stop immediately, preventing other delegates from completing their cleanup.
For example: no footers written to all files because of an Exception from the first delegate, and the main content is already written at this point.