Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatabaseType POSTGRES for the product name EnterpriseDB #4628

Closed
wants to merge 2 commits into from

Conversation

sheelprabhakar
Copy link

@sheelprabhakar sheelprabhakar commented Jun 29, 2024

Issue: [#4627]
EnterpriseDB is an enterprise version of PostGres database, which identifies itself as EnterpriseDB.
Added support for EnterpriseDB by adding the following condition in DatabaseType enum.

else if (StringUtils.hasText(databaseProductName) && databaseProductName.startsWith("EnterpriseDB")) {
			databaseProductName = "PostgreSQL";
		}

Since Enterprise version of PostGre requires license not able to add integration tests

Sheel Prabhakar added 2 commits June 29, 2024 07:50
…ojects#4627

Added one test

Since PostGres EnterpriseDB driver and test container is not available, not written integration test
…ojects#4627

Added one test

Since PostGres EnterpriseDB driver and test container is not available, not written integration test
@sheelprabhakar sheelprabhakar changed the title Gh #4627 Added DatabaseType POSTGRES for the product name EnterpriseDB Gh 4627 Added DatabaseType POSTGRES for the product name EnterpriseDB Jun 29, 2024
@fmbenhassine fmbenhassine changed the title Gh 4627 Added DatabaseType POSTGRES for the product name EnterpriseDB Add DatabaseType POSTGRES for the product name EnterpriseDB Sep 19, 2024
@fmbenhassine
Copy link
Contributor

That's a valid issue. Thank you for raising it and for opening a PR!

LGTM 👍 Rebased and merged as 5fb7b5a. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants