Fix typo in java-config.adoc #4591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that on previous pages, methods with return type Job were being annotated with `@Bean`. I assume this is missing.
fmbenhassine
pushed a commit
that referenced
this pull request
May 13, 2024
fmbenhassine
pushed a commit
that referenced
this pull request
May 13, 2024
|
Good catch! Merged as b06f90a. Thank you for the fix. |
fmbenhassine
added
pr-for: bug
in: documentation
for: backport-to-5.0.x
This was referenced May 13, 2024
natedanner
pushed a commit
to natedanner/spring-projects__spring-batch
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that on previous pages, methods with return type
Jobwere being annotated with@Bean.I assume this is meant to be a Spring Bean in this example.
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
mainbranch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!