Add JobRegistrySmartInitializingSingleton
#4521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2024
fmbenhassine
added a commit
that referenced
this pull request
Feb 6, 2024
- Update reference documentation - Minor test updates
|
LGTM. Rebased and merged as fe26d00, I just refined some tests and updated the reference docs (see d6b6361). I couldn't find a backward compatible fix, but this will be available in 5.1.1 as a replacement of the BPP. I planned the switch to the SIS for 5.2 (#4547). Again, thank you very much for your continuous contributions, really appreciated! |
fmbenhassine
added a commit
that referenced
this pull request
Feb 7, 2024
- Update reference documentation - Minor test updates (cherry picked from commit d6b6361)
fmbenhassine
added
the
for: backport-to-5.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
JobRegistrySmartInitializingSingletonas an alternative toJobRegistryBeanPostProcessor. UsingJobRegistrySmartInitializingSingletoninstead ofJobRegistryBeanPostProcessorallows users to solve problems like #4489, where they configure their own application context and want a mechanism to automatically register job beans with the job registry.As also discussed in #4520, the advantage of
JobRegistrySmartInitializingSingletonoverJobRegistryBeanPostProcessoris that it is not prone to trigger early initializations of beans.One other difference is that
JobRegistrySmartInitializingSingletonwill instantiate all job beans that are declared as lazy (unless the propertyallowEagerClassLoadingofDefaultListableBeanFactoryis set to false). This shouldn't be a problem however as users who do use theJobRegistryare very unlikely to have lazily initialized job beans as that would imply that theJobRegistryis incomplete.