Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotation @Override consistently #4512

Closed
wants to merge 1 commit into from
Closed

Use annotation @Override consistently #4512

wants to merge 1 commit into from

Conversation

hpoettker
Copy link
Contributor

The codebase currently contains some comments with "non-Javadoc", which, I think, are predeccesors in spirit to the @Override annotation and have been auto-generated by IDEs in the past.

This PR removes these remnants and adds the annotation @Override where it is currently missing.

In the test code, I've also removed some methods in support classes that actually don't override anything.

@fmbenhassine
Copy link
Contributor

Merged as 0d1d89c. Thank you for your PR!

@hpoettker hpoettker deleted the use-override-consistently branch December 19, 2023 12:52
@fmbenhassine fmbenhassine modified the milestones: 5.2.0, 5.2.0-M1 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants