Check dirty flag of step execution context before update in inner loop #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 Rebased and merged as 74520a5. Thank you! |
fmbenhassine
added
for: backport-to-5.0.x
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
TaskletStep.ChunkTransactionCallbackpersists updates of theStepExecutionafter each chunk. The update of the step execution context happens in a dedicated method, which is currently called independent of whether the step execution context has actually changed. AsExecutionContextprovides a dirty flag, it can be checked before the update method is called.The proposed change is a performance optimization for simple chunk-oriented steps that e.g. do not save state in between chunks. For such steps, the change results in one database round trip less per chunk.