Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SimpleJobBuilder to start with JobExecutionDecider #4424

Closed
wants to merge 1 commit into from
Closed

Allow SimpleJobBuilder to start with JobExecutionDecider #4424

wants to merge 1 commit into from

Conversation

seonWKim
Copy link
Contributor

@seonWKim seonWKim commented Jul 25, 2023

Modification

  • Add below method to allow users to specify JobExecutionDecider in the start(...) method as an argument.

JobBuilder.java

public JobFlowBuilder start(JobExecutionDecider decider) {
  return new SimpleJobBuilder(this).start(decider);
}

I found that we already have SimpleJobBuilder method that can start with JobExecutionDecider. So I think it's possible to add a method that utilizes SimpleJobBuilder's method(above mentioned) which will allow users to specify JobExecutionDecider as an argument of start method.

Resolves: #4411

@fmbenhassine
Copy link
Contributor

Planning to include this in 5.1.0-M2. Can you please add the modifications as mentioned here: #4359 (comment) ? Currently, the method FlowJobBuilder#start(JobExecutionDecider) is missing in this PR.

Please update the tests of FlowJobBuilder as well and add the javadoc for new public methods. Thank you upfront.

@seonWKim seonWKim marked this pull request as ready for review August 3, 2023 14:34
@seonWKim
Copy link
Contributor Author

seonWKim commented Aug 3, 2023

@fmbenhassine Thank you for the detailed information. I've added missing method(FlowJobBuilder#start(JobExecutionDecider), javadoc and tests.

@fmbenhassine
Copy link
Contributor

Great 👍 Thank you for the updates. Rebased and merged as 3fe3b7f.

Thank you for your contribution!

@seonWKim seonWKim deleted the GH-4411 branch September 17, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to start a job flow definition with a decider
2 participants