Add URL to error message when StaxEventItemReader does not exist #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * EndDocument events. | ||
| */ | ||
| @Test | ||
| public void testNoResource() throws Exception { |
There was a problem hiding this comment.
There is already a test named testStrictness that uses a NonExistentResource for the use case related to the original issue. So I think there is no need to add this new test and its related getBadResource() method. We can update the existent test to assert that the exception's message now contains the URL of the resource.
I will take care of this on merge.
|
Rebased and merged as 4444e46. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1171