Add the constructor with Callable to CallableTaskletAdapter for convenience #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelog
force-pushed
the
add-CallableTaskletAdapter-constructor
branch
3 times, most recently
from
d676bb4 to
1c705c4
Compare
fmbenhassine
added
the
status: waiting-for-triage
benelog
commented
Jan 24, 2021
| */ | ||
| public CallableTaskletAdapter(Callable<RepeatStatus> callable) { | ||
| setCallable(callable); | ||
| afterPropertiesSet(); |
There was a problem hiding this comment.
I referenced the constructor of JdbcTemplate, which also provides both setter and constructor injection.
fmbenhassine
added
in: core
pr-for: feature
and removed
status: waiting-for-triage
benelog
force-pushed
the
add-CallableTaskletAdapter-constructor
branch
from
1c705c4 to
bbdd00c
Compare
|
@fmbenhassine |
fmbenhassine
pushed a commit
that referenced
this pull request
Sep 14, 2023
|
LGTM. Rebased and merged as 31955a0. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the constructor with a
Callable<RepeatStatus>parameter to CallableTaskletAdapter.It makes CallableTaskletAdapter more convenient.
AS-IS:
TO-BE: