BATCH-1613

[snicoll]

Hi Dave,

Here's the patch in BATCH-1613.

HTH

[dsyer]

Stephane, thanks for this. I'll add the multi threaded reader stuff when I get time to add some test cases (or you could provide some).

Note on the process: I like the fact that you flattened your changes down to a single commit. But, you also have two pull requests from the same branch, so it can get hard to distinguish. Better to offer pull requests from independent feature branches in future.

[snicoll]

Yup, I am still new to git and I used the same clone for both requests. I will create a branch of my clone if I have further changes.

Regarding the patch, there are two things to improve:

1. Easy: update a bit the contract of the base class so that I don't have to copy/paste some init code (I have added documentation where I did this). Having a protected getter would solve most of this
2. The implementation is limited to one item = one row which will be an issue I guess. I don't see how we can workaround this limitation easily but if you know some, feel free and I'll review my patch.

[dsyer]

Stephane, I don't have any record of you signing a contributor agreement (https://support.springsource.com/spring_committer_signup). Did you do that yet?

[snicoll]

Hi Dave,

Just signed the agreement.