Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @FunctionalInterface in JobKeyGenerator #4613

Closed
acktsap opened this issue Jun 9, 2024 · 0 comments
Closed

Missing @FunctionalInterface in JobKeyGenerator #4613

acktsap opened this issue Jun 9, 2024 · 0 comments
Labels
for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: core type: enhancement
Milestone

Comments

@acktsap
Copy link
Contributor

acktsap commented Jun 9, 2024

Since #3926 (pr), it's been a public api for spring batch configuration. But there is no @FunctionalInterface in the api.

I think it should be added to the api.

/**
* Strategy interface for the generation of the key used in identifying unique
* {@link JobInstance} objects.
*
* @author Michael Minella
* @author Mahmoud Ben Hassine
* @param <T> The type of the source data used to calculate the key.
* @since 2.2
*/
public interface JobKeyGenerator<T> {
/**
* Method to generate the unique key used to identify a job instance.
* @param source Source information used to generate the key (must not be
* {@code null}).
* @return a unique string identifying the job based on the information supplied.
*/
String generateKey(T source);
}

@acktsap acktsap added status: waiting-for-triage Issues that we did not analyse yet type: feature labels Jun 9, 2024
@fmbenhassine fmbenhassine added in: core type: enhancement for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line and removed status: waiting-for-triage Issues that we did not analyse yet labels Oct 23, 2024
@fmbenhassine fmbenhassine added this to the 5.2.0-RC1 milestone Oct 23, 2024
@fmbenhassine fmbenhassine changed the title No @FunctionalInterface in JobKeyGenerator Missing @FunctionalInterface in JobKeyGenerator Oct 23, 2024
fmbenhassine pushed a commit that referenced this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: core type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants