Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Documentation Uses Deprecated Class StepExecutionListenerSupport #4538

Closed
robertmcnees opened this issue Jan 29, 2024 · 2 comments
Closed
Labels
for: backport-to-5.0.x Issues that will be back-ported to the 5.0.x line for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: documentation status: first-timers-only Issues that we would like first-timers only to work on type: bug
Milestone

Comments

@robertmcnees
Copy link
Contributor

In the reference documentation for controlling flow, the deprecated class StepExectuionListenerSupport is used in the Java code sample.

The doc can be found here. Specifically this code:

public class SkipCheckingListener extends StepExecutionListenerSupport {
    public ExitStatus afterStep(StepExecution stepExecution) {
        String exitCode = stepExecution.getExitStatus().getExitCode();
        if (!exitCode.equals(ExitStatus.FAILED.getExitCode()) &&
              stepExecution.getSkipCount() > 0) {
            return new ExitStatus("COMPLETED WITH SKIPS");
        }
        else {
            return null;
        }
    }
}
@robertmcnees robertmcnees added status: waiting-for-triage Issues that we did not analyse yet type: bug labels Jan 29, 2024
@fmbenhassine fmbenhassine added in: documentation status: first-timers-only Issues that we would like first-timers only to work on and removed status: waiting-for-triage Issues that we did not analyse yet labels Feb 9, 2024
@petrovskimario
Copy link
Contributor

Hello @robertmcnees
I can take this one if it is still available.

@petrovskimario
Copy link
Contributor

@fmbenhassine @robertmcnees

I have submitted a pull request. Please review and if you have any suggestions let me know.

Thanks!

@fmbenhassine fmbenhassine added this to the 5.2.0 milestone Mar 7, 2024
@fmbenhassine fmbenhassine added for: backport-to-5.0.x Issues that will be back-ported to the 5.0.x line for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line labels Mar 7, 2024
fmbenhassine added a commit that referenced this issue Mar 7, 2024
@fmbenhassine fmbenhassine modified the milestones: 5.2.0, 5.2.0-M1 Sep 16, 2024
FBibonne pushed a commit to FBibonne/spring-batch that referenced this issue Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: backport-to-5.0.x Issues that will be back-ported to the 5.0.x line for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: documentation status: first-timers-only Issues that we would like first-timers only to work on type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants