SystemCommandTasklet does not propagate errors

[cachescrubber]

SystemCommandTasklet does not propagate errors

If a command executed by SystemCommandTasklet returns a non zero exit code, the system exit code is mapped to ExitStatus.FAILED. However, the overall step execution status is BatchStatus.COMPLETED, meaning the step (and the job) is completed successfully.

Environment
spring-batch 5.0.3

Steps to reproduce
Create a Job with a SystemCommandTasklet where the system command executed will return a non zero exit code.

Expected behavior
The error should be propagated to the Step, and ultimately to the overall Job execution status.

[cachescrubber]

Example Project: https://github.com/cachescrubber/spring-batch-demo-4483

[hyosyung]

Hi team, I want to work for this issue. Can I?

[fmbenhassine]

@hyosyung Sure! Thank you for your offer to help. Contributions are welcome!

[fmbenhassine]

@hyosyung Have you managed to work on this issue?

I think the way to address this is to throw an exception if the exit code mapper maps the exit code to a failed status, something like:

	if (systemCommandTask.isDone()) {
-		contribution.setExitStatus(systemProcessExitCodeMapper.getExitStatus(systemCommandTask.get()));
-		return RepeatStatus.FINISHED;
+		Integer exitCode = systemCommandTask.get();
+		ExitStatus exitStatus = systemProcessExitCodeMapper.getExitStatus(exitCode);
+		if (ExitStatus.FAILED.equals(exitStatus)) {
+			throw new SystemCommandException("Execution of system command failed with exit code " + exitCode);
+		}
+		else {
+			contribution.setExitStatus(exitStatus);
+			return RepeatStatus.FINISHED;
+		}
	}

This way, the step will be marked as failed correctly. Wdyt? Please let me know if you can contribute a PR along these lines, otherwise I will take care of the fix. Thank you upfront.

[injae-kim]

Hi @fmbenhassine , based on your suggestion I create fix PR #4566 PTAL :)

Thank you for detailed guide!