Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for bulk inserts in MongoItemWriter #4149

Closed
cgrings opened this issue Jul 12, 2022 · 2 comments
Closed

Add support for bulk inserts in MongoItemWriter #4149

cgrings opened this issue Jul 12, 2022 · 2 comments
Labels
in: infrastructure related-to: item-readers-writers type: feature
Milestone
5.1.0-M2

Comments

@cgrings
Copy link
Contributor

cgrings commented Jul 12, 2022

Currently there is support for the upsert and remove operations, I would like to suggest to add support for insert operation.

It would be nice to define an enum based set of operations (INSERT, UPSERT, REMOVE).

UPSERT will be the default operation (same behaviour as it is now) and the 'setDelete' method can be modified to set the REMOVE operation.

I am happy to submit a proposal in case the idea is accepted.
@cgrings cgrings added status: waiting-for-triage Issues that we did not analyse yet type: feature labels Jul 12, 2022
@fmbenhassine fmbenhassine added in: infrastructure and removed status: waiting-for-triage Issues that we did not analyse yet labels Oct 24, 2022
@fmbenhassine
Copy link
Contributor

This is interesting! I guess it would improve the performance for use cases where we are sure we are inserting new documents. This will also be consistent with what we have in the JpaItemWriter: merge and persist.

You are welcome to open a PR! Thank you upfront.

@cgrings cgrings mentioned this issue Apr 13, 2023
Closed
@fmbenhassine fmbenhassine added this to the 5.1.0 milestone Apr 25, 2023
@fmbenhassine fmbenhassine changed the title BulkOperations API Implementation for Insert Operations in MongoItemWriter Add support for bulk inserts in MongoItemWriter Aug 22, 2023
@fmbenhassine fmbenhassine modified the milestones: 5.1.0, 5.1.0-M2 Aug 22, 2023
fmbenhassine added a commit that referenced this issue Aug 22, 2023
@fmbenhassine
Refine contribution #4351
83b2a2a 
- Rename methods to match operation names
- Update Javadocs
- Fix code formatting

Issue #4149
@kgromov
Copy link

kgromov commented Aug 26, 2023

Hi, @fmbenhassine
I'm interested in this enhancement, when it supposed to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: infrastructure related-to: item-readers-writers type: feature
Projects
None yet
Milestone
5.1.0-M2
Development

Successfully merging a pull request may close this issue.

Add Operation Mode in MongoItemWriter cgrings/spring-batch
3 participants
@fmbenhassine @cgrings @kgromov