Run format apply instead of check. #4752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbottard
force-pushed
the
format-apply
branch
from
4a59623 to
9cb1085
Compare
Signed-off-by: Eric Bottard <[email protected]>
ericbottard
force-pushed
the
format-apply
branch
from
9cb1085 to
5888028
Compare
Member
Author
|
@ilayaperumalg Please TAL at this enhanced version. |
ilayaperumalg
approved these changes
Nov 4, 2025
Member
|
Rebased and merged as fb523c8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm tired of running maven only to realize format is broken.
This PR instead runs the format earlier in the lifecycle. I've used this successfully on other Spring projects.
Now, this has a shortcoming: what if people don't run maven locally before submitting their PR / or before us merging it?Well, the formatting may differ and become stale, until it gets fixed again with the next well behaved PR.
I still believe this is better than the current frustrating situation.
If you disagree, we can come up with a more advanced setup where CI runs
checkand developers runapplyautomatically, having the best of both worlds. Let me know. --> DONE