Skip to content

Improve method param name in ChatClient.Builder.defaultAdvisors() #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Improve method param name in ChatClient.Builder.defaultAdvisors() #3856

merged 1 commit into from
Sep 17, 2025

Conversation

@lihuagang03
Copy link
Contributor

@lihuagang03 lihuagang03 commented Jul 20, 2025

Improve method param name in ChatClient.Builder.defaultAdvisors(Advisor...) from advisor to advisors.
Method parameter naming rules should be consistent.

	interface AdvisorSpec {

		AdvisorSpec advisors(Advisor... advisors);

	}
	interface ChatClientRequestSpec {

		ChatClientRequestSpec advisors(Advisor... advisors);

	}
image

sunyuhan1998
sunyuhan1998 approved these changes Jul 20, 2025
View reviewed changes
Copy link
Contributor

@sunyuhan1998 sunyuhan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilayaperumalg ilayaperumalg self-assigned this Sep 17, 2025
@ilayaperumalg ilayaperumalg added this to the 1.1.0.M2 milestone Sep 17, 2025
@ilayaperumalg
Copy link
Member

ilayaperumalg commented Sep 17, 2025

@lihuagang03 Thanks for the PR! and, @sunyuhan1998 Thanks for the review.

@ilayaperumalg ilayaperumalg merged commit 6a3c6a2 into spring-projects:main Sep 17, 2025
1 check passed
spring-builds pushed a commit that referenced this pull request Sep 17, 2025
@lihuagang03 @spring-builds
Improve method param name in ChatClient.Builder.defaultAdvisors() (#3856
67b60d8 
)

Fixes #3856

Signed-off-by: lihuagang03 <[email protected]>
(cherry picked from commit 6a3c6a2)
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
@lihuagang03 @chedim
Improve method param name in ChatClient.Builder.defaultAdvisors() (sp…
aa4adb1 
…ring-projects#3856)

Auto-cherry-pick to 1.0.x
Fixes spring-projects#3856

Signed-off-by: lihuagang03 <[email protected]>
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
@lihuagang03 @Willam2004
Improve method param name in ChatClient.Builder.defaultAdvisors() (sp…
1f77ec2 
…ring-projects#3856)

Auto-cherry-pick to 1.0.x
Fixes spring-projects#3856

Signed-off-by: lihuagang03 <[email protected]>
Signed-off-by: 家娃 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sunyuhan1998 sunyuhan1998 sunyuhan1998 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ilayaperumalg ilayaperumalg

Labels

advisors for: backport-to-1.0.x

Projects

None yet

Milestone

1.1.0.M2

Development

Successfully merging this pull request may close these issues.

3 participants

@lihuagang03 @ilayaperumalg @sunyuhan1998