Skip to content

Conversation

@ilayaperumalg
Copy link
Member

  • Since the non-text documents aren't supported, we need a validation to throw exception if non text documents are encountered
  • Add tests
    • Add test to QdrantVectorStoreIT with the usecase provided by @devMtn30
    • Add simple vector store test for the validation

Fixes #3609

 - Since the non-text documents aren't supported, we need a validation to throw exception if non text documents are encountered
 - Add tests
    - Add test to QdrantVectorStoreIT with the usecase provided by @devMtn30
    - Add simple vector store test for the validation
Fixes spring-projects#3609

Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
@dev-jonghoonpark
Copy link
Contributor

dev-jonghoonpark commented Jun 26, 2025

I also think this approach is more appropriate. 👍

However, I have a personal question.
Is there a specific reason why testNonTextDocuments test was added in QdrantVectorStoreIT.java?
Was it intended to verify the implementation's behavior? Or was it added because it wasn’t included in PR #3653?

@devMtn30
Copy link

Hi @ilayaperumalg, the changes in PR #3687 look excellent! You’ve neatly applied the shared validation logic across all VectorStores and added the automated NPE regression test, so I’m happy to merge it as-is. Thanks again for your thorough review and suggestions! 🙏

@ilayaperumalg
Copy link
Member Author

@dev-jonghoonpark @devMtn30 Thank you for the review!

@dev-jonghoonpark

Is there a specific reason why testNonTextDocuments test was added in QdrantVectorStoreIT.java?
Was it intended to verify the implementation's behavior? Or was it added because it wasn’t included in #3653?

I intended to use one of the vector store ITs and since the report was made from QdrantVectorStore, I ended up choosing one.

@ilayaperumalg ilayaperumalg added this to the 1.1.x milestone Jun 27, 2025
@sobychacko sobychacko merged commit a84256a into spring-projects:main Jun 27, 2025
2 checks passed
sobychacko pushed a commit that referenced this pull request Jun 27, 2025
…3687)

- Since the non-text documents aren't supported, we need a validation to throw exception if non text documents are encountered
 - Add tests
    - Add test to QdrantVectorStoreIT with the usecase provided by @devMtn30
    - Add simple vector store test for the validation
Fixes #3609

Auto-cherry-pick to 1.0.x 

Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
…pring-projects#3687)

- Since the non-text documents aren't supported, we need a validation to throw exception if non text documents are encountered
 - Add tests
    - Add test to QdrantVectorStoreIT with the usecase provided by @devMtn30
    - Add simple vector store test for the validation
Fixes spring-projects#3609

Auto-cherry-pick to 1.0.x 

Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…pring-projects#3687)

- Since the non-text documents aren't supported, we need a validation to throw exception if non text documents are encountered
 - Add tests
    - Add test to QdrantVectorStoreIT with the usecase provided by @devMtn30
    - Add simple vector store test for the validation
Fixes spring-projects#3609

Auto-cherry-pick to 1.0.x 

Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QdrantVectorStore throws NPE when Document contains only media

4 participants