Skip to content

migrate junit4 to junit5 in JdbcChatMemoryRepositoryHsqldbAutoConfigIT #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

migrate junit4 to junit5 in JdbcChatMemoryRepositoryHsqldbAutoConfigIT #3633

merged 1 commit into from
Jun 23, 2025

Conversation

@dev-jonghoonpark
Copy link
Contributor

@dev-jonghoonpark dev-jonghoonpark commented Jun 22, 2025 •
edited
Loading

This PR migrates the JdbcChatMemoryRepositoryHsqldbAutoConfigurationIT test class from JUnit4 to JUnit5.

yuluo-yx
yuluo-yx approved these changes Jun 22, 2025
View reviewed changes
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW, does this require deleting or excluding related dependencies?

@dev-jonghoonpark
Copy link
Contributor Author

dev-jonghoonpark commented Jun 22, 2025 •
edited
Loading

This PR does not modify dependencies.
It simply updates the code to use JUnit 5 for parts where it was found being used.

For reference, JUnit 4 seems to be included in com.squareup.okhttp3:mockwebserver.
As far as I checked, it seems there are no other parts using JUnit 4 except here.

sunyuhan1998
sunyuhan1998 approved these changes Jun 22, 2025
View reviewed changes
Copy link
Contributor

@sunyuhan1998 sunyuhan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilayaperumalg ilayaperumalg self-assigned this Jun 23, 2025
@ilayaperumalg ilayaperumalg added this to the 1.1.x milestone Jun 23, 2025
@ilayaperumalg ilayaperumalg merged commit 28f86bf into spring-projects:main Jun 23, 2025
2 checks passed
spring-builds pushed a commit that referenced this pull request Jun 23, 2025
@dev-jonghoonpark @spring-builds
migrate junit4 to junit5 in JdbcChatMemoryRepositoryHsqldbAutoConfigIT (
d11d3e1 
#3633)

Fixes #3633

Signed-off-by: jonghoonpark <[email protected]>
(cherry picked from commit 28f86bf)
@spring-builds spring-builds mentioned this pull request Jun 23, 2025
Closed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
@dev-jonghoonpark @scionaltera
migrate junit4 to junit5 in JdbcChatMemoryRepositoryHsqldbAutoConfigIT (
4f85555 
spring-projects#3633)

Auto-cherry-pick to 1.0.x

Fixes spring-projects#3633

Signed-off-by: jonghoonpark <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
@dev-jonghoonpark @chedim
migrate junit4 to junit5 in JdbcChatMemoryRepositoryHsqldbAutoConfigIT (
1073a3a 
spring-projects#3633)

Auto-cherry-pick to 1.0.x

Fixes spring-projects#3633

Signed-off-by: jonghoonpark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sunyuhan1998 sunyuhan1998 sunyuhan1998 approved these changes

@yuluo-yx yuluo-yx yuluo-yx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ilayaperumalg ilayaperumalg

Labels

code cleanup for: backport-to-1.0.x status: backported testing

Projects

None yet

Milestone

1.1.0.M1

Development

Successfully merging this pull request may close these issues.

5 participants

@dev-jonghoonpark @sunyuhan1998 @yuluo-yx @ilayaperumalg @spring-builds