This repository has been archived by the owner on May 23, 2024. It is now read-only.
Keep things up to date, support Node 12 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required due to changed behaviour in `require.resolve` in Node 12.
Postponing the upgrade to the latest version until the new extensions API (breaking change) is properly documented (hapijs/joi#2011).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why
This PR upgrades most of the dependencies and migrates the code to new APIs where necessary. All dependencies have been updated to their latest versions as of February 2020 with the exception of @hapi/joi (see below).
Also, a minor fix has been made to how merge strategy files are being imported which makes this project compatible with Node 12.
The @hapi/joi package has only been upgraded to version 15.1.1 since newer versions contain a new extensions API which is incompatible with the old one, and is also not documented yet (hapijs/joi#2011). The migration to this new API will follow in a separate PR.
Steps needed to ensure the issue has been resolved or how to test the feature
All tests should pass.