Credit contributors in ported contributions #52
Conversation
Support configuration of labels that indicate an issue is a forward-port or back-port of another issue, and follow the chain back to the original issue for attribution of a contributor.
scottfrederick
force-pushed
the
ported-contributors
branch
from
38670b7 to
ccb1740
Compare
| String issueNumber = matcher.group(1); | ||
| Issue referencedIssue = this.service.getIssue(issueNumber, this.repository); | ||
| if (referencedIssue != null) { | ||
| return getPortedReferenceIssue(referencedIssue); |
There was a problem hiding this comment.
@scottfrederick I don't think this would work for an issue that is a forward-port of a forward-port, would it? For example, if the original issue is in 2.2.x and we're generating release notes for 2.4.x.
There was a problem hiding this comment.
The recursion will follow a chain of issues that have the same label (e.g. status: forward-port). When the first issue in the chain without the label is encountered, it will be returned up the recursion stack. This does depend on the body regular expression being general enough to capture every version (e.g. Forward port of issue #(\d+).*) The unit test covers this case, but after another look it might be better to split out a separate test case that makes it more clear.
There was a problem hiding this comment.
oh yes, you're right. I misread what the loop does.
Support configuration of labels that indicate an issue is a forward-port
or back-port of another issue, and follow the chain back to the original
issue for attribution of a contributor.