Let TaskRepository depend on database initializers #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've rebased the branch on |
Contributor
Author
|
It's been a while. 😄 I've updated the PR by fixing merge conflicts, applying Unless it's planned to let |
Collaborator
|
LGTM |
Collaborator
|
Thank you for this contribution! and the sample that displayed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #784, which fixed the failing start-up of SCT applications with lazy initialization. When I submitted an analogous PR to Spring Boot for the Spring Batch auto-configuration (spring-projects/spring-boot#27144), @wilkinsona let me know that there is a much more bootiful way to go about it. 😄
The PR is based on #788 as it leverages the
DatabaseInitializationDependencyConfigurerand its detectors, which were introduced with Spring Boot 2.5. When #788 is merged, I'll rebase the branch for this PR onmain.