Skip to content

Remove Kafka binder dependence on KafkaAutoConfiguration #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove Kafka binder dependence on KafkaAutoConfiguration #2362

wants to merge 2 commits into from

Conversation

@onobc
Copy link
Contributor

@onobc onobc commented Apr 25, 2022

See here for details.

Fixes #2349

@onobc onobc mentioned this pull request Apr 25, 2022
Closed
artembilan
artembilan requested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if we go this way, please, consider to make similar changes to the KinesisBinderConfiguration.
See its @Import({ ContextCredentialsAutoConfiguration.class, ContextRegionProviderAutoConfiguration.class }) for the same reason as we have @Import({ KafkaAutoConfiguration.class }) - multi-binder environment.

@onobc
Copy link
Contributor Author

onobc commented Apr 25, 2022 •
edited
Loading

KinesisBinderConfiguration

I must have missed this one @artembilan as I did look in the Kinesis binder module. I will amend this PR to include it as well.

This was referenced May 2, 2022
Closed
Closed
@onobc
Copy link
Contributor Author

onobc commented May 2, 2022

KinesisBinderConfiguration

I must have missed this one @artembilan as I did look in the Kinesis binder module. I will amend this PR to include it as well.

I created spring-cloud/spring-cloud-stream-binder-aws-kinesis#183 to extend this to the Kinesis binder.

@sobychacko
Copy link
Contributor

sobychacko commented May 3, 2022

PR merged upstream.

@sobychacko sobychacko closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artembilan artembilan artembilan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove hard dependency on KafkaAutoConfiguration

3 participants

@onobc @sobychacko @artembilan