some cleanups #985
some cleanups #985
Conversation
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| @RunWith(SpringRunner.class) |
There was a problem hiding this comment.
minor clean-up from junit-4
| parallelism: 5 # parallel containers to split the tests among | ||
| machine: | ||
| image: circleci/classic:201707-01 | ||
| image: ubuntu-2004:202201-02 |
There was a problem hiding this comment.
newer images, these will not work anymore from May 22 (and until then there will be random times when they will not be available), so let's just upgrade
There was a problem hiding this comment.
Ah I changed this on main but forgot to cherry pick it, thanks!
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
fabric-autoconfig tests where failing for me in a diff PR, and I have noticed that this dependency is needed, but it's not in place anymore. I guess it was coming from some spring-boot dependency and now it is not there anymore.
There was a problem hiding this comment.
All of our builds internally are passing both in the 2.1.x and main branches, so I don't think anything changes that would cause us to need this dependency now
There was a problem hiding this comment.
Im really sorry - the error was on my laptop, only. :(
There was a problem hiding this comment.
No worries glad you got if figured it. Still worth making the other changes though.
There was a problem hiding this comment.
right, build is green now
|
seems like maven central is having issues, its either extremely slow or lots of |
| <wiremock.version>2.26.3</wiremock.version> | ||
| <spring-retry.version>1.3.1</spring-retry.version> | ||
| <commons.collections4.version>4.4</commons.collections4.version> | ||
| <bouncycastle.version>1.69</bouncycastle.version> |
There was a problem hiding this comment.
this is the highest version where both clients are compatible, as both need it. I tried 1.70, fabric8 works, but native one fails with a missing method. I will take a look closer into that error and see if an upgrade will help, but that is out of scope here. So for now, this version will do
Codecov Report
@@ Coverage Diff @@
## 2.1.x #985 +/- ##
============================================
- Coverage 51.98% 51.81% -0.18%
+ Complexity 537 532 -5
============================================
Files 134 134
Lines 2868 2868
Branches 280 280
============================================
- Hits 1491 1486 -5
- Misses 1264 1265 +1
- Partials 113 117 +4
Continue to review full report at Codecov.
|
3 participants
No description provided.