clean-up #791
Merged
clean-up #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wind57
commented
May 17, 2021
| private final String namespace; | ||
|
|
||
| private Map<String, String> labels = new HashMap<>(); | ||
| private final Map<String, String> labels; |
There was a problem hiding this comment.
this is redundant, as the only way to set labels is via the constructor.
wind57
commented
May 17, 2021
|
|
||
| public SecretsConfigProperties.NormalizedSource normalize(String defaultName, String defaultNamespace, | ||
| Map<String, String> defaultLabels) { | ||
| final String normalizedName = StringUtils.isEmpty(this.name) ? defaultName : this.name; |
There was a problem hiding this comment.
isEmpty is deprecated, replace it with hasLength. Also final is not really needed
wind57
commented
May 17, 2021
| return new ArrayList<SecretsConfigProperties.NormalizedSource>() { | ||
| { | ||
| add(new SecretsConfigProperties.NormalizedSource(SecretsConfigProperties.this.name, | ||
| return Collections |
There was a problem hiding this comment.
double-brace initialization is a common anti-pattern, replace with a singletonList
wind57
commented
May 17, 2021
|
|
||
| @Override | ||
| public String getConfigurationTarget() { | ||
| return TARGET; |
There was a problem hiding this comment.
unless a String is repeated in code for readability reasons, it is not needed as a constant in the form of private static final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.