Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify clean-up of space stage #1460

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Sep 28, 2023

No description provided.


sudo rm -fr $gcloud_sdk_root
sudo rm -fr $gcloud_global_config
run: sudo apt-get remove google-cloud-cli
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured out the problem. github actions started packaging google-cloud-cli, not google-cloud-sdk (that jlumbroso/free-disk-space uses). As such, instead of manually removing, we can remove the correct package. This does not change anything, it simply simplifies the code a bit

@wind57 wind57 changed the title test simplify clean-up of space stage Sep 28, 2023
@wind57 wind57 marked this pull request as ready for review September 28, 2023 12:02
@wind57
Copy link
Contributor Author

wind57 commented Sep 28, 2023

@ryanjbaxter minor thing...

@ryanjbaxter ryanjbaxter merged commit 8475a54 into spring-cloud:3.0.x Sep 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants