conditional ingress for wiremock pods #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wind57
commented
Sep 16, 2023
| @@ -438,6 +439,33 @@ public void wiremock(String namespace, String path, Phase phase) { | |||
|
|
|||
| } | |||
|
|
|||
| public void wiremock(String namespace, String path, Phase phase, boolean withIngress) { | |||
There was a problem hiding this comment.
the idea is that we have a lot of integration tests that deploy wiremock pods, but not every test needs to have an ingress attached to it. This takes time, though we don't really need it.
|
@ryanjbaxter simple PR that shaves off some time when running integration tests |
ryanjbaxter
reviewed
Sep 17, 2023
| @@ -260,6 +260,7 @@ private void waitForConfigMap(String namespace, ConfigMap configMap, Phase phase | |||
| }); | |||
| } | |||
|
|
|||
| @Deprecated(forRemoval = true) | |||
There was a problem hiding this comment.
why not have this method call the new method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.