Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1317 #1318

Merged
merged 46 commits into from
Apr 24, 2023
Merged

Fix 1317 #1318

merged 46 commits into from
Apr 24, 2023

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Apr 22, 2023

No description provided.

wind57 and others added 30 commits December 4, 2021 07:59
wind57 added 14 commits April 5, 2023 18:22
@@ -41,7 +43,8 @@
* @author Ryan Baxter
*/
@Configuration(proxyBeanMethods = false)
@ConditionalOnKubernetesAndConfigEnabled
@ConditionalOnCloudPlatform(CloudPlatform.KUBERNETES)
@ConditionalOnKubernetesConfigMapsOrSecretsEnabled
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the fix for the issue, everything else are tests covering that

@wind57 wind57 marked this pull request as ready for review April 22, 2023 16:18
@wind57
Copy link
Contributor Author

wind57 commented Apr 24, 2023

@ryanjbaxter one more ready...

@ryanjbaxter ryanjbaxter linked an issue Apr 24, 2023 that may be closed by this pull request
@ryanjbaxter ryanjbaxter merged commit 061709a into spring-cloud:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reload does not work if config is disabled
3 participants