Move namespace metadata #1233
Merged
Move namespace metadata #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wind57
commented
Feb 21, 2023
|
|
||
| for (EndpointSubset endpointSubset : subsets) { | ||
|
|
||
| if (properties.allNamespaces()) { |
There was a problem hiding this comment.
this has moved to the method that computes metadata only. But also fixes kind of an inconsistency. We were returning the namespace metadata (via k8s_namespace key) only for when all-namespaces was true. But why? the namespace is accessible for all other options as-well, so I decided to return it regardless of this setting.
wind57
commented
Feb 21, 2023
| @@ -152,6 +153,7 @@ static Map<String, String> serviceMetadata(String serviceId, Service service, | |||
| serviceMetadata.putAll(portMetadata); | |||
| } | |||
|
|
|||
| serviceMetadata.put(NAMESPACE_METADATA_KEY, namespace); | |||
There was a problem hiding this comment.
namespace metadata is always present and returned.
|
@ryanjbaxter I guess one more minor one. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.