get the namespace from the endpoints instead of the client #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wind57
commented
Feb 18, 2023
| @@ -49,11 +48,8 @@ private KubernetesDiscoveryClientUtils() { | |||
|
|
|||
| } | |||
|
|
|||
| static EndpointSubsetNS subsetsFromEndpoints(Endpoints endpoints, Supplier<String> clientNamespace) { | |||
There was a problem hiding this comment.
now that I have a bit cleaned-up and refactored the code, I can understand better what is going on and make some fixes, not just clean-ups.
This method is called after we find endpoints in different namespace, there is no way for endpoints to be null here, so the check for endpoints != null is obsolete.
Also, endpoints.getSubsets() can not be null either, as the "default" value from fabric8 for getSubsets is an empty List. As such, I dropped these checks altogether.
Then the last point is that getting the namespace from the client is not correct, as we query for endpoints is various namespaces, so the only correct way is to get it from the endpoints itself.
wind57
changed the title
|
@ryanjbaxter ready to be looked at, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.