XD-1439: Prevent module context leak

[ericbottard]

This also should fix a potential problem in the order of closing a stream with multiple processors.

Updated to latest SPR 4.0.3 that fixes leak from event dispatching.

Outdated discussion below

Yet, I still see some weird retention of 1 (out of 4 that are curently created/discarded) ParentLastURLCL when I do the following scenario:

stream create foo --definition "time | tcp"
stream destroy foo.

See the following screenshot:

Will continue to investigate

[ericbottard]

Narrowed the problem down to (showing only strong refs):

Removing the

        this.application.parent(parent);

line in SimpleModule.initialize() cures the problem.

[ilayaperumalg]

But removing that line

        this.application.parent(parent);

would mean, the module context would not get reference to the beans from global context (xd-global beans). Currently, module context specifically needs "mbeanServer" bean (if jmx enabled) and batch job beans (for job modules).

[ericbottard]

Of course. My point was to narrow down the search.

As a matter of fact I now know for certain what causes the problem (for
certain kinds of modules). It's a cache from ApplicationEvent type
(subclass) to listeners held by the parent context (when you add a listener
in a child context, the parent context gets it too).
By holding to the class object, the classloader is retained, and then every
loaded class by that CL from there.

See AbstractApplicationEventMulticaster.ListenerCacheKey

On Wed, Mar 26, 2014 at 8:44 AM, Ilayaperumal Gopinathan <
[email protected]> wrote:

But removing that line

    this.application.parent(parent);

would mean, the module context would not get reference to the beans from
global context (xd-global beans). Currently, module context specifically
needs "mbeanServer" bean (if jmx enabled) and batch job beans (for job
modules).

Reply to this email directly or view it on GitHubhttps://github.com//pull/669#issuecomment-38657017
.

[cppwfs]

Merged

[cppwfs]

Refer to issue https://jira.spring.io/browse/XD-1443