support for 3.x version of querydsl

[vbichov]

Hi,

There are a few changes in querydsl (I found 1: querydsl/querydsl#186) that reqire changes in the spring-data-jdbc-ext package.

The above change causes QueryDslJdbcTemplate.newSqlQuery() to throw ClassNotFoundException.

Are those changes planed in the near future?

Thank you,
Vitaly

[jrodalo]

+1

[leotu]

+1

[trisberg]

Looks like we are getting enough votes on this - I have created an issue in JIRA - https://jira.springsource.org/browse/DATAJDBC-51

Just a matter of getting the time to work on this. Pull request greatly appreciated :)

[nabedge]

+1
I really want to use Spring-data with QueryDSL 3.x with serious mind !

[eddie-craftsmanshipcounts]

Absolutely agree this is needed.

Speaking as someone that's not stopped by your not having this support, it would have been kind if certain fields - in particular SQLTemplates - were made protected. That way, a subclass could be created to overcome the extremely small change that is required to be compatible with the "next version" of QueryDSL.

I'd probably add protected getters for dialect (SQLTemplates) and dataSource too. That way, you're preserving encapsulation while making those elements available to sub-classes.

[eddie-craftsmanshipcounts]

Okay, it wasn't quite that simple :-) I wound up having to just override the whole class, which I did by copying it to a new file under com.mycompany.org.springframework.data.jdbc.query and changing the bits that made the build unhappy. Still, it wasn't much work at all. In total, I had to

• Copy the class.
• Update the instantiation of SQLQuery.
• Ensure the import for SQLQueryImpl was removed.
• Update countDistinct(SQLQuery) to invoke liveQuery.distinct().count() instead of liveQuery.countDistinct()

In the end, I made another project to house both the generated query classes as well as my QueryDslJdbcTemplate theft and customization. That way, all the icky bits are all in the same bucket. This allowed me to keep my main persistence project extremely clean.

Sorry for the long comment. I figured I'd try and document a work-around in case someone is really blocked by the current state of things. If I had Git on this box, I'd have submitted a patch. Maybe next time. There's really no reason for this to be a block for anyone though. We're all programmers, right? ;-)

[timowest]

The usage of a thread bound connection for direct query, insert etc usage without the need to put it back into another object for execution would be great.

So this

public Customer findById(Long id) {
        SQLQuery sqlQuery = template.newSqlQuery()
                .from(qCustomer)
                .where(qCustomer.id.eq(id));
        return template.queryForObject(sqlQuery,
                BeanPropertyRowMapper.newInstance(Customer.class),
                qCustomer.all());
}

would turn into

public Customer findById(Long id) {
        return template.newSqlQuery()
                .from(qCustomer)
                .where(qCustomer.id.eq(id));
                .singleResult(qCustomer);
}

For the DML cases there is even more code saving.

Querydsl could provide a hook for custom exception translation if that is needed.

[nabedge]

Are there some load map or schedule ?
Please, pretty please enhance spring-data-jdbc for this issue !

[trisberg]

I've updated the project to build against Querydsl 3.3.0

This is now available in 1.1.0.BUILD-SNAPSHOT (see http://projects.spring.io/spring-data-jdbc-ext/ for build info)

We'll consider other suggestions made in this thread - to improve the chances of the changes making it to next release - add a JIRA issue here - https://jira.springsource.org/browse/DATAJDBC or submit a pull request

Appreciate you patience and looking forward to any feedback or additional suggestions

[trisberg]

Released new milestone - 1.1.0.M1 with the latest code for Querydsl 3.3.0

Grab it with

<dependencies>
    <dependency>
        <groupId>org.springframework.data</groupId>
        <artifactId>spring-data-jdbc-ext</artifactId>
        <version>1.1.0.M1</version>
    </dependency>
</dependencies>
<repositories>
    <repository>
        <id>spring-milestones</id>
        <name>Spring Milestones</name>
        <url>http://repo.spring.io/milestone</url>
        <snapshots>
            <enabled>false</enabled>
        </snapshots>
    </repository>
</repositories>

More build details here: http://projects.spring.io/spring-data-jdbc-ext/

[mdiskin]

+1

[nabedge]

Excellent !
Now I 'm going to use 1.1.0M1 with QueryDSL3.3.0 .
I will report if any problem.
Thank you trisberg !

[riccisi]

Hi,
I tried to add the new dependency you specified but Maven complains about missing dependency:

E:\Sviluppo\Progetti\java\experiment\projection>mvn clean install
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Building Unnamed - projection:projection:jar:1.0-SNAPSHOT
[INFO]    task-segment: [clean, install]
[INFO] ------------------------------------------------------------------------
[INFO] [clean:clean {execution: default-clean}]
[INFO] Deleting directory E:\Sviluppo\Progetti\java\experiment\projection\target

[INFO] [resources:resources {execution: default-resources}]
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources,
i.e. build is platform dependent!
[INFO] Copying 1 resource
Downloading: http://repo.spring.io/milestone/org/springframework/data/spring-dat
a-jdbc-ext/1.1.0.M1/spring-data-jdbc-ext-1.1.0.M1.pom
[INFO] Unable to find resource 'org.springframework.data:spring-data-jdbc-ext:po
m:1.1.0.M1' in repository spring-milestones (http://repo.spring.io/milestone)
Downloading: http://repo1.maven.org/maven2/org/springframework/data/spring-data-
jdbc-ext/1.1.0.M1/spring-data-jdbc-ext-1.1.0.M1.pom
[INFO] Unable to find resource 'org.springframework.data:spring-data-jdbc-ext:po
m:1.1.0.M1' in repository central (http://repo1.maven.org/maven2)
Downloading: http://repo.spring.io/milestone/org/springframework/data/spring-dat
a-jdbc-ext/1.1.0.M1/spring-data-jdbc-ext-1.1.0.M1.jar
[INFO] Unable to find resource 'org.springframework.data:spring-data-jdbc-ext:ja
r:1.1.0.M1' in repository spring-milestones (http://repo.spring.io/milestone)
Downloading: http://repo1.maven.org/maven2/org/springframework/data/spring-data-
jdbc-ext/1.1.0.M1/spring-data-jdbc-ext-1.1.0.M1.jar
[INFO] Unable to find resource 'org.springframework.data:spring-data-jdbc-ext:ja
r:1.1.0.M1' in repository central (http://repo1.maven.org/maven2)
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.

Missing:
----------
1) org.springframework.data:spring-data-jdbc-ext:jar:1.1.0.M1

  Try downloading the file manually from the project website.

  Then, install it using the command:
      mvn install:install-file -DgroupId=org.springframework.data -DartifactId=s
pring-data-jdbc-ext -Dversion=1.1.0.M1 -Dpackaging=jar -Dfile=/path/to/file

  Alternatively, if you host your own repository you can deploy the file there:

      mvn deploy:deploy-file -DgroupId=org.springframework.data -DartifactId=spr
ing-data-jdbc-ext -Dversion=1.1.0.M1 -Dpackaging=jar -Dfile=/path/to/file -Durl=
[url] -DrepositoryId=[id]

  Path to dependency:
        1) projection:projection:jar:1.0-SNAPSHOT
        2) org.springframework.data:spring-data-jdbc-ext:jar:1.1.0.M1

----------
1 required artifact is missing.

for artifact:
  projection:projection:jar:1.0-SNAPSHOT

from the specified remote repositories:
  central (http://repo1.maven.org/maven2),
  spring-milestones (http://repo.spring.io/milestone)



[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4 seconds
[INFO] Finished at: Wed Feb 05 10:25:00 CET 2014
[INFO] Final Memory: 12M/495M
[INFO] ------------------------------------------------------------------------

I saw that in the repository there are a bunch of zip files instead of standard Maven artifactory layout...