Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change initialize process to be compatible with Rails 7 #406

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Change initialize process to be compatible with Rails 7 #406

merged 1 commit into from
Jul 10, 2022

Conversation

adrianryt
Copy link
Contributor

@adrianryt adrianryt commented Jul 6, 2022 •
edited
Loading

While trying to create sandbox application with Rails 7 I got uninitialized constant Spree::Gateway error.
This bug comes from Rails 7 autoloader changes (link). The fix is to change initialize process.

@mdavo6
Copy link

mdavo6 commented Jul 6, 2022 •
edited
Loading

Thanks @adrianryt , I was facing the same issue with this particular line yesterday. Issue is also present on Rails 6. Proposed fix worked for me 👍

@rafalcymerys
Copy link
Member

@damianlegawiec I know you made similar changes in spree/spree_core for Rails 7 compatibility.
Could you take a look at this one and confirm that the change makes sense? We tested it locally and it seems to work fine, but I wanted to make sure that we didn't miss any edge-cases or side effects.

@damianlegawiec damianlegawiec merged commit 8215a4a into spree:main Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianlegawiec damianlegawiec damianlegawiec approved these changes

@rafalcymerys rafalcymerys rafalcymerys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianryt @mdavo6 @rafalcymerys @damianlegawiec