Overhaul Spec Tests #576
Open
Overhaul Spec Tests #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalcymerys
reviewed
Jan 2, 2023
There was a problem hiding this comment.
Great PR @MatthewKennedy , thanks for that! 🙌
I just have one comment regarding one method that you removed - I think it should stay as it is, but I'll need your feedback on that.
| @@ -60,10 +60,6 @@ def self.frontend_available? | |||
| @@frontend_available ||= Gem::Specification.find_all_by_name('spree_frontend').any? | |||
| end | |||
|
|
|||
| def self.api_available? | |||
There was a problem hiding this comment.
I'm not sure if this is safe to be removed, it's used e.g. in lib/spree/auth/engine.rb:43, to determine whether to load decorators for API classes.
| @@ -31,7 +31,7 @@ def self.activate | |||
| Rails.configuration.cache_classes ? require(c) : load(c) | |||
| end | |||
| if Spree::Auth::Engine.backend_available? | |||
| Dir.glob(File.join(File.dirname(__FILE__), "../../controllers/backend/*/*/*_decorator*.rb")) do |c| | |||
| Dir.glob(File.join(File.dirname(__FILE__), "../../controllers/backend/**/*_decorator*.rb")) do |c| | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:enafter tests that change the locale to:fr.log_outtolog_out_via_frontend_user_menuto avoid tests on admin side using it by mistake.Fix Admin Sign Out spec, it was not testing the sign out from the admin side, rather it was logging in, redirecting to the frontend and logging back out again.
Now creates an admin user, logs into the admin, redirects to the admin as expected, and then logs out from the admin UI