Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record identifying information with each experiment #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davidsj
Copy link
Contributor

@davidsj davidsj commented Oct 2, 2015

This makes it easier to keep track of experiment configuration and parameters automatically. Note that "git diff HEAD" will include both staged and unstaged changes.

Example:

~/dqn/test-runs/version_info_10-02-07-56-18_0p00025_0p99$ cat cmdline 
./run_nature.py --experiment-prefix /home/dsj/dqn/test-runs/version_info --rom breakout
~/dqn/test-runs/version_info_10-02-07-56-18_0p00025_0p99$ cat git-rev-parse 
71061e912c138c1a00bac65e41d15634e14f0585
~/dqn/test-runs/version_info_10-02-07-56-18_0p00025_0p99$ cat git-diff 
diff --git a/deep_q_rl/ale_agent.py b/deep_q_rl/ale_agent.py
index fc3b04b..ea0f5a8 100755
--- a/deep_q_rl/ale_agent.py
+++ b/deep_q_rl/ale_agent.py
@@ -57,8 +57,6 @@ class NeuralAgent(object):
             f.write('\n')
         with open(os.path.join(self.exp_dir, 'git-rev-parse'), 'w') as f:
             f.write(subprocess.check_output(['git', 'rev-parse', 'HEAD']))
-        with open(os.path.join(self.exp_dir, 'git-status'), 'w') as f:
-            f.write(subprocess.check_output(['git', 'status']))
         with open(os.path.join(self.exp_dir, 'git-diff'), 'w') as f:
             f.write(subprocess.check_output(['git', 'diff', 'HEAD']))

@spragunr
Copy link
Owner

spragunr commented Oct 4, 2015

This is a good idea, but it's duplicating some of the functionality from PR #44 against the dev branch.

I've been trying to confine code changes that involve significant reorganizations or changes to the interface to the dev branch, only updating the master branch directly if there is an important bug-fix or other non-disruptive change. That's fallen by the wayside a bit as there have been a stream of critical improvements going directly into master, and I haven't had the resources to vet and merge the changes in dev. I'll merge PR #44 as soon as the author fixes some minor issues with it. Maybe at that point you could re-target this against dev with just the git version stuff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants