Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoder_cls argument to CacheFileHandler #941

Merged
merged 4 commits into from
Feb 12, 2023
Merged

Add encoder_cls argument to CacheFileHandler #941

merged 4 commits into from
Feb 12, 2023

Conversation

shawncruz
Copy link
Contributor

@shawncruz shawncruz commented Feb 12, 2023 •
edited
Loading

Resolves #940

@shawncruz shawncruz marked this pull request as ready for review February 12, 2023 21:08
stephanebruckert
stephanebruckert reviewed Feb 12, 2023
View reviewed changes
Copy link
Member

@stephanebruckert stephanebruckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! just one comment on the changelog

CHANGELOG.md Outdated
@@ -39,6 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Unit tests for new releases, passing limit parameter with minimum and maximum values of 1 and 50
- Unit tests for categories, omitting country code to test global releases
- Added `CODE_OF_CONDUCT.md`
- Added optional `encoder_cls` argument to `CacheFileHandler`, which overwrite default encoder for token before writing to disk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add it in the unreleased section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@stephanebruckert stephanebruckert merged commit b3f308d into spotipy-dev:master Feb 12, 2023
@shawncruz shawncruz deleted the issues/940 branch February 12, 2023 22:59
@stephanebruckert
Copy link
Member

stephanebruckert commented Feb 12, 2023 •
edited
Loading

There likely won't be a release for it so soon but feel free to use @master or @b3f308d in your code for now :-)

For example https://stackoverflow.com/a/20101940/1515819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanebruckert stephanebruckert stephanebruckert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide optional Encoder argument to CacheFileHandler
2 participants
@shawncruz @stephanebruckert