Use sbt-bom #5414
Merged
Use sbt-bom #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
commented
Jul 3, 2024
build.sbt
Outdated
Comment on lines
479
to
480
| // slf4j-bom only available for v2 | ||
| "org.slf4j" % "slf4j-api" % slf4jVersion |
There was a problem hiding this comment.
we absolutely need to downgrade to slf4j v1 as some deps are pulling v2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5414 +/- ##
==========================================
- Coverage 61.10% 61.09% -0.01%
==========================================
Files 310 310
Lines 11060 11060
Branches 769 769
==========================================
- Hits 6758 6757 -1
- Misses 4302 4303 +1 ☔ View full report in Codecov by Sentry. |
shnapz
reviewed
Jul 3, 2024
RustedBones
force-pushed
the
sbt-bom
branch
2 times, most recently
from
b8b5557
to
8b02d72
Compare
Use sbt-bom to pin beam, gcp and jackson versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage
sbt-bomplugin and override versions forbeamgcpjacksonnetty