Added Precommit hooks #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ianjmacintosh! Thanks for taking this up! I think this PR is still missing some updates to the Feel free to make a test commit to make sure the hook runs and then we can squash it later 😄. Let me know if you need anymore help. Also no need to sign an agreement 👍 |
_@spotify/web-scripts_ and _husky_ need to be installed if we expect to run them as precommit hooks. Installed via ``` npm install --save-dev @spotify/web-scripts husky ```
Copied from Tim Pope without permission See https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
This reverts commit c9243e6. Result of test: ``` Ians-MacBook-Pro:reactochart ian$ vim CONTRIBUTING.md Ians-MacBook-Pro:reactochart ian$ git add CONTRIBUTING.md Ians-MacBook-Pro:reactochart ian$ git commit husky > pre-commit (node v10.15.3) ↓ Stashing changes... [skipped] → No partially staged files found... ✔ Running linters... [175-add-precommit-hooks c9243e6] Add a file to test precommit hooks 1 file changed, 49 insertions(+) create mode 100644 CONTRIBUTING.md ```
|
@krissalvador27 Doneski's! Result of test: |
|
I'm not sure what the expected outcome of this precommit hook is, but that looks like a success to me. If there's anything else that should change for this PR, lmk and I'll be happy to take a look |
|
Looks like it's running perfectly @ianjmacintosh! Expected outcome is that our linter runs before each commit, blocking developers from committing any code with eslint errors. 😄 |
Closed
|
Hey @ianjmacintosh, looks like the husky version is only supported in |
krissalvador27
added a commit
that referenced
this pull request
Nov 20, 2019
This reverts commit 777320a.
krissalvador27
added a commit
that referenced
this pull request
Nov 20, 2019
krissalvador27
added a commit
that referenced
this pull request
Nov 20, 2019
Merged
krissalvador27
added a commit
that referenced
this pull request
Nov 20, 2019
Sounds like the right thing to me, thanks for the update. I'm not sure when 3.0.0 is expected, but I'm guessing it's soon enough that it wouldn't make sense to figure out a workaround that's compatible with older versions of node in the meantime. |
acmei
added a commit
that referenced
this pull request
Dec 3, 2019
krissalvador27
added a commit
that referenced
this pull request
Dec 16, 2019
* Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs
acmei
added a commit
that referenced
this pull request
Dec 16, 2019
* 'master' of github.com:spotify/reactochart: v3.0.0 release 3.0.0 v3.0.0 release (#195) Revert "Added Precommit hooks (#191)" (#193) Remove docs from build (#192) Added Precommit hooks (#191) Update docs in master (#189) 2.0.2 release (#188) Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Fix warnings in tests and add SankeyNodeTerminal tests (#184) decorate events and remove original decorations (#182) Changelog casing fix
acmei
added a commit
that referenced
this pull request
Dec 16, 2019
* Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release
acmei
added a commit
that referenced
this pull request
Dec 18, 2019
…-v3-0-1 * 'master' of github.com:spotify/reactochart: v3.0.1 release 3.0.1 Prettier ignore build (#212) Fix xy plot lesson in docs (#211) v3.0.0 release 3.0.0 v3.0.0 release (#195) Revert "Added Precommit hooks (#191)" (#193) Remove docs from build (#192) Added Precommit hooks (#191) Update docs in master (#189) 2.0.2 release (#188) Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Fix warnings in tests and add SankeyNodeTerminal tests (#184) decorate events and remove original decorations (#182) Changelog casing fix
acmei
added a commit
that referenced
this pull request
Dec 18, 2019
* Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release
install
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Added Precommit hooks * Update package.json for precommit hooks
install
pushed a commit
that referenced
this pull request
Feb 25, 2020
install
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs
iezer
added a commit
that referenced
this pull request
Feb 25, 2020
* Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Update sinon to the latest version 🚀 (#216) * chore(package): update sinon to version 8.0.0 * chore(package): update lockfile package-lock.json * Update eslint-config-prettier to the latest version 🚀 (#217) * chore(package): update eslint-config-prettier to version 6.8.0 * chore(package): update lockfile package-lock.json * Update cross-env to the latest version 🚀 (#225) * chore(package): update cross-env to version 7.0.0 * chore(package): update lockfile package-lock.json * Update mocha to the latest version 🚀 (#226) * chore(package): update mocha to version 7.0.1 * chore(package): update lockfile package-lock.json * Rename upcoming deprecated Lifecycle methods (#214) * rename lifecycle methods in src * update examples * fix weird prettier stuff * Greenkeeper/@spotify/eslint config base 6.0.0 (#227) * chore(package): update @spotify/eslint-config-base to version 6.0.0 Closes #219 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/prettier config 6.0.0 (#230) * chore(package): update @spotify/prettier-config to version 6.0.0 Closes #221 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/eslint config react 6.0.0 (#228) * chore(package): update @spotify/eslint-config-react to version 6.0.0 Closes #220 * chore(package): update lockfile package-lock.json * fix lint errors Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Remove deprecated Lifecycle hooks (#234) * remove unsafe calls from animated examples * remove unsafe calls from TreeMap * remove unsafe calls from KernelDensityEstimation * remove unsafe calls from LineChart * remove Unsafe calls from SankeyDiagram * remove deprecated lifecycle hooks from ZoomContainer * 3.0.2 * v3.0.2 release Co-authored-by: Kris Salvador <[email protected]> Co-authored-by: Tanay Vardhan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anita <[email protected]> Co-authored-by: Ian MacIntosh <[email protected]> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <[email protected]>
acmei
added a commit
that referenced
this pull request
Jun 18, 2020
* Update docs * rebuild docs * Update docs * Update docs (#190) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs * Gh pages v3 (#210) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Gh pages v3 0 1 (#213) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Gh pages v3.0.2 (#237) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Update sinon to the latest version 🚀 (#216) * chore(package): update sinon to version 8.0.0 * chore(package): update lockfile package-lock.json * Update eslint-config-prettier to the latest version 🚀 (#217) * chore(package): update eslint-config-prettier to version 6.8.0 * chore(package): update lockfile package-lock.json * Update cross-env to the latest version 🚀 (#225) * chore(package): update cross-env to version 7.0.0 * chore(package): update lockfile package-lock.json * Update mocha to the latest version 🚀 (#226) * chore(package): update mocha to version 7.0.1 * chore(package): update lockfile package-lock.json * Rename upcoming deprecated Lifecycle methods (#214) * rename lifecycle methods in src * update examples * fix weird prettier stuff * Greenkeeper/@spotify/eslint config base 6.0.0 (#227) * chore(package): update @spotify/eslint-config-base to version 6.0.0 Closes #219 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/prettier config 6.0.0 (#230) * chore(package): update @spotify/prettier-config to version 6.0.0 Closes #221 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/eslint config react 6.0.0 (#228) * chore(package): update @spotify/eslint-config-react to version 6.0.0 Closes #220 * chore(package): update lockfile package-lock.json * fix lint errors Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Remove deprecated Lifecycle hooks (#234) * remove unsafe calls from animated examples * remove unsafe calls from TreeMap * remove unsafe calls from KernelDensityEstimation * remove unsafe calls from LineChart * remove Unsafe calls from SankeyDiagram * remove deprecated lifecycle hooks from ZoomContainer * 3.0.2 * v3.0.2 release Co-authored-by: Kris Salvador <[email protected]> Co-authored-by: Tanay Vardhan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anita <[email protected]> Co-authored-by: Ian MacIntosh <[email protected]> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <[email protected]> * docs Co-authored-by: Kris Salvador <[email protected]> Co-authored-by: Isaac Ezer <[email protected]> Co-authored-by: Tanay Vardhan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ian MacIntosh <[email protected]> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <[email protected]>
acmei
added a commit
that referenced
this pull request
Dec 10, 2020
* Update docs * rebuild docs * Update docs * Update docs (#190) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs * Gh pages v3 (#210) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Gh pages v3 0 1 (#213) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Gh pages v3.0.2 (#237) * Changelog casing fix * decorate events and remove original decorations (#182) * Fix warnings in tests and add SankeyNodeTerminal tests (#184) * Update event handler test on XYPlot * Fix Bar warnings in tests * Fix XLine warnings in tests * Fix AreaBarChart warnings * Update SankeyDiagram tests * Bump mixin-deep from 1.3.1 to 1.3.2 (#186) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.4.0 to 1.4.3 (#185) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * 2.0.2 release (#188) * 2.0.2 release * Update package-lock * 2.0.2 * Update docs in master (#189) * Update docs * rebuild docs * Update docs * Update docs * Added Precommit hooks (#191) * Added Precommit hooks * Update package.json for precommit hooks * Remove docs from build (#192) * Update package-lock.json * Remove docs from build process * Disable cache for travis builds * Revert "Added Precommit hooks (#191)" (#193) This reverts commit 777320a. * v3.0.0 release (#195) * Revert "Revert "Added Precommit hooks (#191)" (#193)" (#194) This reverts commit c6ae448. * Update dependencies to enable Greenkeeper 🌴 (#187) * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore(package): update lockfile package-lock.json * Fix issues with cross-env upgrade * Update jsdom setup * Remove docs from npm build command * Remove support for node < 8 * Update docs based on raw-loader upgrade * Add Pie Chart Styles (#201) * WIP: PieChart prop of getValue -> slice, added pieSliceStyle prop to PieChart * replace example code color picker with d3 function * update docs * address pr comments * undo slice destructure * update docs and fix CleanWebpack package usage * doc update * docs update * remove doc build config * Doc updates (#207) * update punctuation for AreaBarChart * require data as a prop for AreaBarChart * update docs for AreaChart && add required next to props that are required * update Bar docs * update BarChart docs * update ColorHeatmap docs * FunnelChart docs * update FunnelChart docs * update Histogram docs * update KernelDensityEstimation docs * update LineChart docs * MarkerLineChart docs update * RangeBarChart doc update * add iteration through enum types for docs, update sankey diagram docs * remove extra spaces * update docs for TreeMap * Bar doc updates * update all the docs with more descriptive prop types * docs update for XLine * update the rest of the docs * 3.0.0 * v3.0.0 release * Fix xy plot lesson in docs (#211) * Fix xy plot lesson in docs * Add TODO regarding Interaction and GettersAndAccessors lesson and fix those imports just in case * Prettier ignore build (#212) * Add prettierignore to ignore build files * ignore node modules * 3.0.1 * v3.0.1 release * Update sinon to the latest version 🚀 (#216) * chore(package): update sinon to version 8.0.0 * chore(package): update lockfile package-lock.json * Update eslint-config-prettier to the latest version 🚀 (#217) * chore(package): update eslint-config-prettier to version 6.8.0 * chore(package): update lockfile package-lock.json * Update cross-env to the latest version 🚀 (#225) * chore(package): update cross-env to version 7.0.0 * chore(package): update lockfile package-lock.json * Update mocha to the latest version 🚀 (#226) * chore(package): update mocha to version 7.0.1 * chore(package): update lockfile package-lock.json * Rename upcoming deprecated Lifecycle methods (#214) * rename lifecycle methods in src * update examples * fix weird prettier stuff * Greenkeeper/@spotify/eslint config base 6.0.0 (#227) * chore(package): update @spotify/eslint-config-base to version 6.0.0 Closes #219 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/prettier config 6.0.0 (#230) * chore(package): update @spotify/prettier-config to version 6.0.0 Closes #221 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Greenkeeper/@spotify/eslint config react 6.0.0 (#228) * chore(package): update @spotify/eslint-config-react to version 6.0.0 Closes #220 * chore(package): update lockfile package-lock.json * fix lint errors Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> * Remove deprecated Lifecycle hooks (#234) * remove unsafe calls from animated examples * remove unsafe calls from TreeMap * remove unsafe calls from KernelDensityEstimation * remove unsafe calls from LineChart * remove Unsafe calls from SankeyDiagram * remove deprecated lifecycle hooks from ZoomContainer * 3.0.2 * v3.0.2 release Co-authored-by: Kris Salvador <[email protected]> Co-authored-by: Tanay Vardhan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anita <[email protected]> Co-authored-by: Ian MacIntosh <[email protected]> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <[email protected]> * add CODEOWNERS file (#262) * Bump elliptic from 6.5.2 to 6.5.3 (#266) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bar chart gradient example in docs (#268) Co-authored-by: Isaac Ezer <[email protected]> * Sankey sorting (#269) * remove deprecated refs definition This old usage of defining refs via a string is deprecated and seems to break when debugging reactochart using `npm link` locally. * add Sankey Sorting Function hooks Co-authored-by: Isaac Ezer <[email protected]> * 3.2.0 * v3.2.0 release * Fix YAxisLabels formatting example (#271) The current example did not demonstrate label color/weight change, since the final label (`label.text`) never was `20.00`. * 3.2.1 * 3.2.1 release * [A11y] add aria-hidden attributes to XYPlot (#273) * add aria-hidden attributes to XYPlot elements * more granual application of aria-hidden * 3.2.2 * Add changelog edit for 3.2.2 * v3.2.2 release * v3.2.2 release * fix docs build file Co-authored-by: Kris Salvador <[email protected]> Co-authored-by: Isaac Ezer <[email protected]> Co-authored-by: Tanay Vardhan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ian MacIntosh <[email protected]> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Erica Hyman <[email protected]> Co-authored-by: Isaac Ezer <[email protected]> Co-authored-by: Marko Bonaći <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
I saw @Patil2099 had a merge conflict in #178 but I couldn't add his fork as a remote since GitHub shows it as
unknown repository. To get around this, I pasted the contents of https://github.com/spotify/reactochart/commit/e1703852667099377d176031479bbff3defece19.patch into a temp file on my local filesystem then ran$ git am -3 < patch-file, resolved the merge conflicts as best as I knew how (looks like the version bumped from2.0.0-rc-1to2.0.2?), and opened this PR from my new branch.This is my first time contributing to this project (👋🏻), please let me know if I need to sign a license agreement. Thanks all!