Fix Seq Validation #219
Merged
Fix Seq Validation #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackdingilian
commented
Feb 28, 2022
|
|
||
| import com.spotify.elitzur.{DataInvalidException, IllegalValidationException, MetricsReporter} | ||
| import java.lang.{StringBuilder => JStringBuilder} | ||
| import com.spotify.elitzur.{ |
There was a problem hiding this comment.
Sorry, running scalafmt on this made it seem like a much larger change. The material changes are in SeqLikeValidator (line 184), validationLoop (line 327), and validateField (line 424)
jackdingilian
commented
Feb 28, 2022
| @@ -0,0 +1,207 @@ | |||
| package com.spotify.elitzur.validators | |||
There was a problem hiding this comment.
I think some of our core tests got dropped when we open sourced. Adding some simple testing here so we aren't relying on ValidatorDoFnTest as much
idreeskhan
approved these changes
Feb 28, 2022
| @@ -125,6 +125,7 @@ object CaseClassValidators { | |||
| val fiveNFiveVal: Validator[FiveNestedFiveFields] = genFiveNestedFive() | |||
| } | |||
|
|
|||
| //scalastyle:off magic.number | |||
There was a problem hiding this comment.
Need a correspond on toggle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach to Seq validation fails on Seqs containing nested records when it tries to get the ValidationType name from the nested record. It needs the ValidationType name in order to publish metrics. To avoid this problem this splits the field level validation logic into its own function that writes the metrics. This can then be re-used from
DerivedValidatorandSeqLikeValidatoragainst anyFieldValidatorI benchmarked this against master and there was no performance degradation (it was actually a bit faster but might just be variance)