fix(go): implement StateHandler for proper shutdown #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement StateHandler interface to ensure OpenFeature SDK calls provider shutdown. Add WaitGroup synchronization to prevent race conditions during cleanup. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> wip
nicklasl
force-pushed
the
fix-go-shutdown-bug
branch
from
19c8c4b to
9cd6dc5
Compare
nicklasl
commented
Nov 6, 2025
|
|
||
| // Shutdown closes the provider and cleans up resources | ||
| // Init initializes the provider (part of StateHandler interface) | ||
| func (p *LocalResolverProvider) Init(evaluationContext openfeature.EvaluationContext) error { |
Member
Author
There was a problem hiding this comment.
The absense of this function was the reason that openfeature.Shutdown() didn't work.
nicklasl
commented
Nov 6, 2025
nicklasl
force-pushed
the
fix-go-shutdown-bug
branch
from
45ed5fe to
c277c3f
Compare
andreas-karlsson
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes shutdown flow in the Go OpenFeature provider by implementing the
StateHandlerinterface.Problem
The OpenFeature Go SDK only calls
Shutdown()on providers that implement the fullStateHandlerinterface (bothInit()andShutdown()methods). Without this,openfeature.Shutdown()would not trigger provider cleanup, leaving logs unflushed and resources unreleased.Solution
StateHandlerinterface withInit()andShutdown()methodssync.WaitGroupto prevent race conditions during shutdownTesting