This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Handle broken FileDescriptorGaugeSet in Java 9 #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileDescriptorGaugeSet is broken at least in OpenJDK 9, throwing an exception
like this:
Any metrics that would have been reported AFTER this metric will not be reported
at all, which is pretty bad - no rates, etc would be reported when this throws.
Until upstream (ideally codahale metrics, possibly semantic-metrics) is patched
to handle this properly we reimplement the FileDescriptorSetGauge from
semantic-metrics in a way that handles this safely.